fix: preserve exception tracebacks in logs#1261
Merged
zhongwen666 merged 5 commits intoJul 20, 2026
Merged
Conversation
Timandes
marked this pull request as ready for review
July 20, 2026 05:01
zhongwen666
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StandardFormatterwhen logging withexc_infologging.exception_traceback_enabledYAML configuration andROCK_LOGGING_EXCEPTION_TRACEBACK_ENABLEenvironment-variable overrideRoot cause
StandardFormatter.format()built the final message directly fromrecord.getMessage()and did not appendrecord.exc_info. Exceptions with an empty message, such ashttpx.PoolTimeout(""), therefore produced onlyError in http_proxy:with neither an exception type nor a traceback.Impact
Exception tracebacks are enabled by default. Operators can restore the previous behavior with either:
or:
An explicitly set environment variable takes precedence over YAML configuration.
Validation
uv run pytest tests/unit/test_logger.py tests/unit/test_config.py tests/unit/admin/test_logging_config.py -q— 83 passeduv run ruff check rock/logger.py rock/env_vars.py rock/config.py rock/admin/main.py tests/unit/test_logger.py tests/unit/test_config.py tests/unit/admin/test_logging_config.pyuv run ruff format --check rock/logger.py rock/env_vars.py rock/config.py rock/admin/main.py tests/unit/test_logger.py tests/unit/test_config.py tests/unit/admin/test_logging_config.pyFixes #1260