Fix starrocks expression partition parse#6508
Open
qingzheguo-flash wants to merge 3 commits intoalibaba:masterfrom
Open
Fix starrocks expression partition parse#6508qingzheguo-flash wants to merge 3 commits intoalibaba:masterfrom
qingzheguo-flash wants to merge 3 commits intoalibaba:masterfrom
Conversation
fix StarRocksCreateTableParserTest.java exists unit tests
fix StarRocksCreateTableParserTest.java exists unit tests
|
|
Author
|
Hi @lingo-xp . Could you please help review this PR? Thank you! |
wenshao
reviewed
Feb 8, 2026
| accept(Token.LPAREN); | ||
| for (; ; ) { | ||
| if (lexer.token() == Token.RPAREN) { | ||
| if (lexer.token() == Token.LPAREN) { |
Member
There was a problem hiding this comment.
Here you can use nextIf, like this:
if (lexer.nextIf(Token.LPAREN)) {
//We don't need to use accept here.
}
qingzheguo-flash
force-pushed
the
fix-starrocks-expr-partition
branch
from
cf78d5a to
aaaa815
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix starrocks expression partition sql parse:
before fix starrocks parser always expect a "(" after we defined partition columns, but starrocks support expression partition now, this will cause parse failure when we create expression partition table:https://docs.starrocks.io/docs/table_design/data_distribution/expression_partitioning/#partitioning-based-on-the-column-expression-since-v31
so I fixed support for expression partition.
Also fixed some exist unit tests in StarRocksCreateTableParserTest