Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing call to writeColon in JSONWriter.writeNameValue #3405

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

mpfaff
Copy link

@mpfaff mpfaff commented Mar 16, 2025

What this PR does / why we need it?

See #3224:

The implementation of JSONWriter.writeNameValue is broken. It is missing a call to writeColon between the writeName and writeAny.

Summary of your change

Add the aforementioned missing call, fixing the issue.

Please indicate you've done the following:

  • Made sure tests are passing and test coverage is added if needed.
  • Made sure commit message follow the rule of Conventional Commits specification.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed.

If I recall correctly, I tried running tests at the time I implemented this fix but they failed due to (seemingly) relying on the host system having a particular time zone.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@wenshao
Copy link
Member

wenshao commented Mar 28, 2025

请签署CLA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants