Skip to content

fix bug for issue #3419#3498

Closed
jujn wants to merge 6 commits into
alibaba:mainfrom
jujn:main
Closed

fix bug for issue #3419#3498
jujn wants to merge 6 commits into
alibaba:mainfrom
jujn:main

Conversation

@jujn
Copy link
Copy Markdown
Collaborator

@jujn jujn commented Apr 15, 2025

What this PR does / why we need it?

fix bug for issue #3419

Please indicate you've done the following:

  • [√] Made sure tests are passing and test coverage is added if needed.
  • [√] Made sure commit message follow the rule of Conventional Commits specification.
  • [√] Considered the docs impact and opened a new docs issue or PR with docs changes if needed.

jujn added 2 commits April 15, 2025 18:58
fix bug for issue #3419
fix bug for issue #3419
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 15, 2025

CLA assistant check
All committers have signed the CLA.

@jujn
Copy link
Copy Markdown
Collaborator Author

jujn commented Apr 17, 2025

Who can help me? The Java CI above shows' 4 checks not yet completed '. But I checked the test logs and they were all caused by Ubuntu 20.04 stopping the service.

Map.Entry entry = (Map.Entry) value;
JSONObject object = new JSONObject();
object.put(entry.getKey().toString(), entry.getValue());
set(index, object);
Copy link
Copy Markdown
Member

@wenshao wenshao Apr 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set(index, 
	JSONObject.of(entry.getKey().toString(), entry.getValue());

=======
Can we do this in a more concise way?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a beginner. Thank you for your guidance. But I don't know how to modify the PR. Do I need to resubmit it?

@wenshao
Copy link
Copy Markdown
Member

wenshao commented Apr 17, 2025

Who can help me? The Java CI above shows' 4 checks not yet completed '. But I checked the test logs and they were all caused by Ubuntu 20.04 stopping the service.

The build failure under Ubuntu has nothing to do with you. I am dealing with this error

@jujn
Copy link
Copy Markdown
Collaborator Author

jujn commented Apr 17, 2025

谁能帮助我?上面的 Java CI 显示“4 项检查尚未完成”。但是我查看了测试日志,它们都是由 Ubuntu 20.04 停止服务引起的。

Ubuntu 下的构建失败与您无关。我正在处理此错误

Thanks for your help!

@jujn jujn closed this by deleting the head repository Apr 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants