Skip to content

Conversation

@yanxutao89
Copy link
Collaborator

What this PR does / why we need it?

fix enable serialize and deserialize when using PropertyNamingStrategy

Summary of your change

Please indicate you've done the following:

  • Made sure tests are passing and test coverage is added if needed.
  • Made sure commit message follow the rule of Conventional Commits specification.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed.

@codecov-commenter
Copy link

codecov-commenter commented May 7, 2025

Codecov Report

Attention: Patch coverage is 77.58621% with 13 lines in your changes missing coverage. Please review.

Project coverage is 72.97%. Comparing base (80c005c) to head (d34c39e).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
...alibaba/fastjson2/reader/ObjectReaderProvider.java 66.66% 6 Missing and 4 partials ⚠️
core/src/main/java/com/alibaba/fastjson2/JSON.java 87.50% 0 Missing and 2 partials ⚠️
...rc/main/java/com/alibaba/fastjson2/JSONReader.java 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3536      +/-   ##
============================================
+ Coverage     72.32%   72.97%   +0.65%     
- Complexity    23180    24253    +1073     
============================================
  Files           682      682              
  Lines         90759    93864    +3105     
  Branches      20582    21850    +1268     
============================================
+ Hits          65638    68501    +2863     
- Misses        16688    16832     +144     
- Partials       8433     8531      +98     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

}
return object;
} finally {
context.provider.setNameFilter(null);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

如果Context被多个线程同时使用,这里有问题的

@wenshao
Copy link
Member

wenshao commented May 24, 2025

我担心在ReaderProvider上增加NameFilter支持,对性能有很大影响

@yanxutao89
Copy link
Collaborator Author

我担心在ReaderProvider上增加NameFilter支持,对性能有很大影响

这个也仅针对存在NameFilter的情况吧,影响范围还算可控。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants