fix: declare java.xml module dependency for Java 9+ modular usage#7619
Open
JinlongLiao wants to merge 2 commits into
Open
fix: declare java.xml module dependency for Java 9+ modular usage#7619JinlongLiao wants to merge 2 commits into
JinlongLiao wants to merge 2 commits into
Conversation
wenshao
approved these changes
Apr 25, 2026
Member
wenshao
left a comment
There was a problem hiding this comment.
No issues found. LGTM! ✅ — gpt-5.5 via Qwen Code /review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
This PR fixes the
IllegalAccessErrorthat occurs when using fastjson2 (v2.0.61) in Java 9+ modular environments. The error is caused by missingjava.xmlmodule declaration insrc/main/moditect/module-info.java, while the code internally referencesorg.w3c.dom.Nodefromjava.xml.Without this fix, users cannot properly use fastjson2 in modularized projects, as the JVM prevents access to
java.xmlclasses.Summary of your change
src/main/moditect/module-info.javato explicitly declarerequires java.xml;.ObjectWriterProviderand related XML handling code can accessorg.w3c.dom.NodewithoutIllegalAccessError.Please indicate you've done the following: