fix: ISO8601 should take priority over yyyyMMddHHmmss in Instant write, for issue #4003#7632
Open
wenshao wants to merge 1 commit into
Open
fix: ISO8601 should take priority over yyyyMMddHHmmss in Instant write, for issue #4003#7632wenshao wants to merge 1 commit into
wenshao wants to merge 1 commit into
Conversation
…e, for issue #4003 When the JSONWriter.Context has dateFormat="iso8601" (the runtime form that fastjson1's SerializerFeature.UseISO8601DateFormat resolves into) ISO8601 must take priority over any string-pattern shape flags such as yyyyMMddhhmmss19/14/8/10. Previously the codec evaluated those flags purely against the codec instance + context's pattern flags, so a configuration that had been set up with dateFormat="yyyy-MM-dd HH:mm:ss" and later switched to ISO8601 could still hit the yyyyMMddhhmmss19 path and produce "2026-02-24 14:50:00" instead of "2026-02-24T14:50:00Z". Compute a single iso8601 effective flag and gate the yyyyMMddhhmmss shape paths on !iso8601, so an explicit ISO8601 request always wins.
|
wenshao seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JSONWriter.ContexthasdateFormat="iso8601"(the runtime form that fastjson1'sSerializerFeature.UseISO8601DateFormatresolves into) ISO8601 must take priority over any string-pattern shape flags such asyyyyMMddhhmmss19/14/8/10.dateFormat="yyyy-MM-dd HH:mm:ss"and later switched to ISO8601 could still hit theyyyyMMddhhmmss19path and produce"2026-02-24 14:50:00"instead of"2026-02-24T14:50:00Z".iso8601effective flag and gate theyyyyMMddhhmmssshape paths on!iso8601, so an explicit ISO8601 request always wins.Fixes #4003.
Test plan
Issue4003test covering: ISO8601 alone, ISO8601 after a defaultyyyy-MM-dd HH:mm:ss, defaultyyyy-MM-dd HH:mm:sswithout ISO8601 (regression), and no-format default.*Instant*,*ISO8601*,*DateTimeCodec*,Issue*tests pass (37 tests).