-
Notifications
You must be signed in to change notification settings - Fork 350
[client] fix: throw LogOffsetOutOfRangeException when scan offset ttl log #737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fluss-client/src/test/java/com/alibaba/fluss/client/table/scanner/log/FlussLogITCase.java
Outdated
Show resolved
Hide resolved
fluss-client/src/test/java/com/alibaba/fluss/client/table/scanner/log/FlussLogITCase.java
Outdated
Show resolved
Hide resolved
fluss-client/src/main/java/com/alibaba/fluss/client/table/scanner/log/LogFetcher.java
Outdated
Show resolved
Hide resolved
fluss-client/src/main/java/com/alibaba/fluss/client/table/scanner/log/LogFetcher.java
Outdated
Show resolved
Hide resolved
fluss-client/src/main/java/com/alibaba/fluss/client/table/scanner/log/LogFetchCollector.java
Outdated
Show resolved
Hide resolved
Hi @gyang94 do you have time to update the PR? If not available in the recent days, I can help to update it and merge it. |
@wuchong Thanks for review. I will update it in this or next week. |
@wuchong updated. please check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#588 has fixed this problem. So I rebased the branch and kept the tests to verify that the problem is fixed. Will merge it once CI passes.
Purpose
Linked issue: close #521
Brief change log
Based on comments in issue #521 , this PR did:
p.s. Based on the comments from @loserwang1024 , this empty records check may be necessary for some cases.
I guess it is going to avoid several null records CompletedFetch (without error) in the first several polls.
But we can create a new issue ticket to resolve those cases.
Tests
Add
FlussLogITCase
.This test need to set a small ttl and wait for log clean up. It may not be good to reuse the cluster in existing IT cases. Thus add a new IT case for it.
API and Format
Documentation