[client] fix: throw LogOffsetOutOfRangeException when scan offset ttl log #737
+137
−18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #521
Brief change log
Based on comments in issue #521 , this PR did:
p.s. Based on the comments from @loserwang1024 , this empty records check may be necessary for some cases.
I guess it is going to avoid several null records CompletedFetch (without error) in the first several polls.
But we can create a new issue ticket to resolve those cases.
Tests
Add
FlussLogITCase
.This test need to set a small ttl and wait for log clean up. It may not be good to reuse the cluster in existing IT cases. Thus add a new IT case for it.
API and Format
Documentation