[client] fix: throw LogOffsetOutOfRangeException when scan offset ttl log#737
Merged
wuchong merged 5 commits intoapache:mainfrom Apr 27, 2025
Merged
[client] fix: throw LogOffsetOutOfRangeException when scan offset ttl log#737wuchong merged 5 commits intoapache:mainfrom
wuchong merged 5 commits intoapache:mainfrom
Conversation
wuchong
reviewed
Apr 14, 2025
fluss-client/src/test/java/com/alibaba/fluss/client/table/scanner/log/FlussLogITCase.java
Outdated
Show resolved
Hide resolved
fluss-client/src/test/java/com/alibaba/fluss/client/table/scanner/log/FlussLogITCase.java
Outdated
Show resolved
Hide resolved
fluss-client/src/main/java/com/alibaba/fluss/client/table/scanner/log/LogFetcher.java
Outdated
Show resolved
Hide resolved
fluss-client/src/main/java/com/alibaba/fluss/client/table/scanner/log/LogFetcher.java
Show resolved
Hide resolved
fluss-client/src/main/java/com/alibaba/fluss/client/table/scanner/log/LogFetchCollector.java
Outdated
Show resolved
Hide resolved
Member
|
Hi @gyang94 do you have time to update the PR? If not available in the recent days, I can help to update it and merge it. |
Contributor
Author
|
@wuchong Thanks for review. I will update it in this or next week. |
Contributor
Author
|
@wuchong updated. please check. |
polyzos
pushed a commit
to polyzos/fluss
that referenced
this pull request
Apr 27, 2025
ZmmBigdata
pushed a commit
to ZmmBigdata/fluss
that referenced
this pull request
Jun 20, 2025
polyzos
pushed a commit
to polyzos/fluss
that referenced
this pull request
Aug 30, 2025
polyzos
pushed a commit
to Alibaba-HZY/fluss
that referenced
this pull request
Aug 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #521
Brief change log
Based on comments in issue #521 , this PR did:
p.s. Based on the comments from @loserwang1024 , this empty records check may be necessary for some cases.
I guess it is going to avoid several null records CompletedFetch (without error) in the first several polls.
But we can create a new issue ticket to resolve those cases.
Tests
Add
FlussLogITCase.This test need to set a small ttl and wait for log clean up. It may not be good to reuse the cluster in existing IT cases. Thus add a new IT case for it.
API and Format
Documentation