fix(shared): array.move without length change missing …#4263
Open
charlzyx wants to merge 1 commit intoalibaba:formily_nextfrom
Open
fix(shared): array.move without length change missing …#4263charlzyx wants to merge 1 commit intoalibaba:formily_nextfrom
charlzyx wants to merge 1 commit intoalibaba:formily_nextfrom
Conversation
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request, please make sure the following is done...
masterorformily_next.npm test).npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.Please do not delete the above content
修复 #4205 问题
What have you changed?
相比于原来的 splice 方案
会引发的两次length变化, 缺少了这里的 reactions https://github.com/alibaba/formily/blob/v2.3.2/packages/reactive/src/reaction.ts#L140
我猜测这样导致了 array 的引用被认为是没有变化的, ArrayItems 里面的刷新逻辑跟之前有偏差;
这涉及到 react 经典的 为什么尽量不使用数组的 index 做key 与 formliy 响应式模型的一点点冲突;
TODO: 后续我会在深入研究之后在这个pr之后进行补充