fix(react): fix some render issue in non web browser environment#4335
Open
wenchiangh wants to merge 1 commit intoalibaba:formily_nextfrom
Open
fix(react): fix some render issue in non web browser environment#4335wenchiangh wants to merge 1 commit intoalibaba:formily_nextfrom
wenchiangh wants to merge 1 commit intoalibaba:formily_nextfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request, please make sure the following is done...
masterorformily_next.npm test).npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.Please do not delete the above content
What have you changed?
formily-react,render.tswill try to create adivelement when load module, this action may throw a error in some non web browser. But inrenderfunction,env.portalDOMjust work withenv.createPortal, so I try to createenv.portalDOMlazy whenenv.createPortalnotundefined(or loaded). I also add a environment test before create adivelement.templatenot support in non web browser environment, andglobalThisPolyfill?.navigator?.product === 'ReactNative'just support RN, then I try to testtemplateelement support in current environment directly.