Skip to content

fix(a11y): add alt text to images for better accessibility #4349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
huangkevin-apr wants to merge 1 commit into
base: formily_next
Choose a base branch
from
+26 −7
Open

fix(a11y): add alt text to images for better accessibility #4349

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions docs/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,10 @@ export default () => (
scale={1.2}
>
<a href="//designable-antd.formilyjs.org" target="_blank" rel="noreferrer">
<img src="//img.alicdn.com/imgextra/i2/O1CN01eI9FLz22tZek2jv7E_!!6000000007178-2-tps-3683-2272.png" />
<img
src="//img.alicdn.com/imgextra/i2/O1CN01eI9FLz22tZek2jv7E_!!6000000007178-2-tps-3683-2272.png"
alt="Formily Form Builder"
/>
</a>
</Section>
)
Expand All @@ -83,7 +86,10 @@ export default () => (
titleStyle={{ paddingBottom: 100, fontWeight: 'bold' }}
>
<a href="//core.formilyjs.org" target="_blank" rel="noreferrer">
<img src="//img.alicdn.com/imgextra/i4/O1CN019qbf1b1ChnTfT9x3X_!!6000000000113-55-tps-1939-1199.svg" />
<img
src="//img.alicdn.com/imgextra/i4/O1CN019qbf1b1ChnTfT9x3X_!!6000000000113-55-tps-1939-1199.svg"
alt="Formily Core"
/>
</a>
</Section>
)
Expand Down Expand Up @@ -125,7 +131,10 @@ export default () => (
titleStyle={{ paddingBottom: 20, fontWeight: 'bold' }}
>
<QrCodeGroup>
<QrCode link="//img.alicdn.com/imgextra/i1/O1CN011zlc5b1uu1BDUpNg1_!!6000000006096-2-tps-978-1380.png" />
<QrCode
link="//img.alicdn.com/imgextra/i1/O1CN011zlc5b1uu1BDUpNg1_!!6000000006096-2-tps-978-1380.png"
alt="Formily Community QR Code"
/>
</QrCodeGroup>
</Section>
)
Expand Down
15 changes: 12 additions & 3 deletions docs/index.zh-CN.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,10 @@ export default () => (
scale={1.2}
>
<a href="//designable-antd.formilyjs.org" target="_blank" rel="noreferrer">
<img src="//img.alicdn.com/imgextra/i2/O1CN01eI9FLz22tZek2jv7E_!!6000000007178-2-tps-3683-2272.png" />
<img
src="//img.alicdn.com/imgextra/i2/O1CN01eI9FLz22tZek2jv7E_!!6000000007178-2-tps-3683-2272.png"
alt="Formily 表单设计器"
/>
</a>
</Section>
)
Expand All @@ -83,7 +86,10 @@ export default () => (
titleStyle={{ paddingBottom: 100 }}
>
<a href="//core.formilyjs.org" target="_blank" rel="noreferrer">
<img src="//img.alicdn.com/imgextra/i3/O1CN01iEwHrP1NUw84xTded_!!6000000001574-55-tps-1939-1199.svg" />
<img
src="//img.alicdn.com/imgextra/i3/O1CN01iEwHrP1NUw84xTded_!!6000000001574-55-tps-1939-1199.svg"
alt="Formily 内核"
/>
</a>
</Section>
)
Expand Down Expand Up @@ -125,7 +131,10 @@ export default () => (
titleStyle={{ paddingBottom: 20, fontWeight: 'bold' }}
>
<QrCodeGroup>
<QrCode link="//img.alicdn.com/imgextra/i1/O1CN011zlc5b1uu1BDUpNg1_!!6000000006096-2-tps-978-1380.png" />
<QrCode
link="//img.alicdn.com/imgextra/i1/O1CN011zlc5b1uu1BDUpNg1_!!6000000006096-2-tps-978-1380.png"
alt="Formily 社区二维码"
/>
</QrCodeGroup>
</Section>
)
Expand Down
3 changes: 2 additions & 1 deletion docs/site/QrCode.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import './QrCode.less'
export interface IQrCodeProps {
title?: React.ReactNode
link?: string
alt?: string
}

export const QrCode: React.FC<React.PropsWithChildren<IQrCodeProps>> = (
Expand All @@ -15,7 +16,7 @@ export const QrCode: React.FC<React.PropsWithChildren<IQrCodeProps>> = (
<div className="qrcode-title-content">{props.title}</div>
</div>
<div className="qrcode-content">
<img src={props.link} />
<img src={props.link} alt={props.alt} />
</div>
</div>
)
Expand Down
Loading