-
Notifications
You must be signed in to change notification settings - Fork 577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add variable from secret when applying istio cr #1877
base: main
Are you sure you want to change the base?
Conversation
a09a1dd
to
1a4daf9
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1877 +/- ##
==========================================
+ Coverage 35.91% 43.47% +7.55%
==========================================
Files 69 77 +8
Lines 11576 12374 +798
==========================================
+ Hits 4157 5379 +1222
+ Misses 7104 6659 -445
- Partials 315 336 +21
🚀 New features to boost your workflow:
|
// TemplateProcessor handles template substitution in configs | ||
type TemplateProcessor struct { | ||
// getSecret is a function that retrieves secrets by name and namespace | ||
getSecret func(namespace, name string) (*v1.Secret, error) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个函数我建议抽象成 getValue,把从什么来源获取的逻辑也包在里面,例如可能未来会支持要从 nacos 获取某个配置项的值
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews