-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support conditional LLM model mapping #1952
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1952 +/- ##
==========================================
+ Coverage 35.91% 43.61% +7.70%
==========================================
Files 69 79 +10
Lines 11576 12685 +1109
==========================================
+ Hits 4157 5532 +1375
+ Misses 7104 6807 -297
- Partials 315 346 +31 🚀 New features to boost your workflow:
|
} | ||
|
||
if (!JsonArrayIterate( | ||
configuration, "conditionalModelMappings", [&](const json& conditional_item) -> bool { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to add unit tests, and also need to provide documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
633f87b
to
ce628d4
Compare
4decf8e
to
cbef9a5
Compare
cbef9a5
to
ae67361
Compare
Ⅰ. Describe what this PR did
Support conditional LLM model mapping, so user can configure difference mapping rules for different consumers, a.k.a. consumer-level model aliases.
Config sample:
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews