Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check NOAUTH response and init redis #2032

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Fengxq2014
Copy link
Contributor

Ⅰ. Describe what this PR did

  1. 增加clusterConfMap存储Init方法传入的redis配置
  2. 解析redis返回内容之后判断NOAUTH关键字
  3. 使用clusterConfMap中的配置进行初始化,如果初始化成功重新调用redisCall
  4. 防止无限递归,增加ShareData进行判断是否在递归

Ⅱ. Does this pull request fix one issue?

fix: #2000

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.72%. Comparing base (ef31e09) to head (5e0c88a).
Report is 425 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2032      +/-   ##
==========================================
+ Coverage   35.91%   43.72%   +7.81%     
==========================================
  Files          69       79      +10     
  Lines       11576    12728    +1152     
==========================================
+ Hits         4157     5565    +1408     
+ Misses       7104     6816     -288     
- Partials      315      347      +32     

see 75 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

优化redis client,支持在识别到 NOAUTH 响应的时候,重新初始化
2 participants