-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support config store and redis configuration optional in mcp server #2035
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (16.32%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #2035 +/- ##
==========================================
+ Coverage 35.91% 43.59% +7.68%
==========================================
Files 69 79 +10
Lines 11576 12754 +1178
==========================================
+ Hits 4157 5560 +1403
+ Misses 7104 6846 -258
- Partials 315 348 +33
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The overall logic is fine, but the mcp server logic at the uid granularity needs to be completely decoupled and controlled through an independent configuration item, such as enableUserLevelServer: true
Ⅰ. Describe what this PR did
support config handler and store in mcp server
feat: support mcp server redis configuration optional
fix bug of redis not enabled response body
feat: add internal IP check for config path access
update mcp-server.so to golang-filter.so
fix: support panic recover in go routine and pprof in mcp server
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews