feat: support config store and redis configuration optional in mcp server#2035
Merged
johnlanni merged 29 commits intoalibaba:mainfrom Apr 14, 2025
Merged
feat: support config store and redis configuration optional in mcp server#2035johnlanni merged 29 commits intoalibaba:mainfrom
johnlanni merged 29 commits intoalibaba:mainfrom
Conversation
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (16.66%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #2035 +/- ##
==========================================
+ Coverage 35.91% 43.66% +7.75%
==========================================
Files 69 79 +10
Lines 11576 12752 +1176
==========================================
+ Hits 4157 5568 +1411
+ Misses 7104 6836 -268
- Partials 315 348 +33
🚀 New features to boost your workflow:
|
johnlanni
requested changes
Apr 10, 2025
Collaborator
johnlanni
left a comment
There was a problem hiding this comment.
The overall logic is fine, but the mcp server logic at the uid granularity needs to be completely decoupled and controlled through an independent configuration item, such as enableUserLevelServer: true
johnlanni
requested changes
Apr 11, 2025
johnlanni
reviewed
Apr 14, 2025
VinceCui
pushed a commit
to VinceCui/higress
that referenced
this pull request
May 21, 2025
ink-hz
pushed a commit
to ink-hz/higress-ai-capability-auth
that referenced
this pull request
Nov 5, 2025
ISADBA
pushed a commit
to ISADBA/higress
that referenced
this pull request
Jan 13, 2026
ISADBA
pushed a commit
to ISADBA/higress
that referenced
this pull request
Jan 13, 2026
johnlanni
pushed a commit
that referenced
this pull request
Jan 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
support config handler and store in mcp server
feat: support mcp server redis configuration optional
fix bug of redis not enabled response body
feat: add internal IP check for config path access
update mcp-server.so to golang-filter.so
fix: support panic recover in go routine and pprof in mcp server
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews