Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support config store and redis configuration optional in mcp server #2035

Open
wants to merge 24 commits into
base: main
Choose a base branch
from

Conversation

Jing-ze
Copy link
Collaborator

@Jing-ze Jing-ze commented Apr 9, 2025

Ⅰ. Describe what this PR did

support config handler and store in mcp server
feat: support mcp server redis configuration optional
fix bug of redis not enabled response body
feat: add internal IP check for config path access
update mcp-server.so to golang-filter.so
fix: support panic recover in go routine and pprof in mcp server

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Apr 9, 2025

Codecov Report

Attention: Patch coverage is 16.32653% with 41 lines in your changes missing coverage. Please review.

Project coverage is 43.59%. Comparing base (ef31e09) to head (0aa5bdc).
Report is 435 commits behind head on main.

Files with missing lines Patch % Lines
pkg/ingress/kube/configmap/mcp_server.go 16.32% 40 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (16.32%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2035      +/-   ##
==========================================
+ Coverage   35.91%   43.59%   +7.68%     
==========================================
  Files          69       79      +10     
  Lines       11576    12754    +1178     
==========================================
+ Hits         4157     5560    +1403     
+ Misses       7104     6846     -258     
- Partials      315      348      +33     
Files with missing lines Coverage Δ
pkg/ingress/kube/configmap/mcp_server.go 39.85% <16.32%> (ø)

... and 74 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Jing-ze Jing-ze marked this pull request as ready for review April 10, 2025 09:48
Copy link
Collaborator

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overall logic is fine, but the mcp server logic at the uid granularity needs to be completely decoupled and controlled through an independent configuration item, such as enableUserLevelServer: true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants