Skip to content

feature: mixed sorting envoyfilter #3391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Aias00 wants to merge 4 commits into
base: main
Choose a base branch
from
+28 −0
Open

feature: mixed sorting envoyfilter #3391

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
52ed01f
feat: add wasmPhase and wasmPriority fields to EnvoyFilter CRD for mi…
Aias00 Jan 26, 2026
fecebec
Merge branch 'refs/heads/main' into feature/mixed-sorting-envoyfilter…
Aias00 Jan 26, 2026
3388f4a
Merge branch 'main' into feature/mixed-sorting-envoyfilter-wasmplugin
Aias00 Feb 7, 2026
b97c614
feat(crds): add wasmPhase and wasmPriority fields to EnvoyFilter for …
Aias00 Feb 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions hgctl/pkg/manifests/istiobase/crds/crd-all.gen.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3209,6 +3209,20 @@ spec:
within a context.
format: int32
type: integer
wasmPhase:
description: Determines where in the filter chain this EnvoyFilter should
be injected for mixed sorting with WasmPlugins.
enum:
- UNSPECIFIED_PHASE
- AUTHN
- AUTHZ
- STATS
type: string
wasmPriority:
description: Determines ordering of EnvoyFilter in the same wasmPhase
for mixed sorting with WasmPlugins.
format: int32
type: integer
Comment on lines +3212 to +3225
Copy link

Copilot AI Feb 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description/linked issue describe implementing mixed sorting behavior between EnvoyFilter and WasmPlugin, but in this repo the only change appears to be adding wasmPhase/wasmPriority to the CRD schema. A repo-wide search shows no Go/proto code referencing these fields, so they will currently be inert (accepted by the API server but ignored by the control-plane logic). If this repo is expected to provide the mixed-sorting behavior, please include the corresponding API/type + sorting logic changes here; otherwise, clarify in the PR description that this is only the CRD/installer piece and ensure version compatibility with the control-plane that actually consumes the fields.

Copilot uses AI. Check for mistakes.
workloadSelector:
properties:
labels:
Expand Down
Loading