Skip to content

enrich kubeskoop mellanox rdma metrics - #343

Merged
Lyt99 merged 1 commit into
alibaba:mainfrom
BSWANG:main
Aug 15, 2025
Merged

enrich kubeskoop mellanox rdma metrics#343
Lyt99 merged 1 commit into
alibaba:mainfrom
BSWANG:main

Conversation

@BSWANG

@BSWANG BSWANG commented Aug 14, 2025

Copy link
Copy Markdown
Collaborator

No description provided.

@BSWANG
BSWANG requested review from Lyt99 and Copilot August 14, 2025 05:42

This comment was marked as outdated.

Comment thread pkg/exporter/probe/rdma/rdma.go Fixed

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enriches kubeskoop's RDMA metrics collection by adding support for Mellanox hardware counters from the sysfs filesystem and expanding resource summary entries. The changes enhance RDMA monitoring capabilities with additional counter metrics and improved test coverage.

Key changes:

  • Adds sysfs-based counter metrics collection for RDMA devices
  • Expands resource summary entries to include "srq" (shared receive queue)
  • Adds comprehensive test coverage for the new functionality

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
pkg/exporter/probe/rdma/rdma.go Implements sysfs counter collection, adds netlink interface abstraction, and integrates new metrics into collection pipeline
pkg/exporter/probe/rdma/rdma_test.go Adds comprehensive test suite covering sysfs metrics, error handling, and mock-based testing
pkg/exporter/probe/rdma/mellanox.go Expands Mellanox counter definitions with general and hardware counters documentation
go.mod Adds stretchr/objx test dependency

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread pkg/exporter/probe/rdma/rdma.go Outdated
Comment thread pkg/exporter/probe/rdma/rdma.go Outdated
Signed-off-by: bingshen.wbs <bingshen.wbs@alibaba-inc.com>
@Lyt99
Lyt99 merged commit 70355a7 into alibaba:main Aug 15, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants