fix: support cgroup v2 - #349
Merged
Merged
Conversation
The tasksInsidePodCgroup function was hardcoded to use the 'memory' subsystem path which only works with cgroup v1. This commit adds support for cgroup v2: 1. Add cgroupV2Mode flag and isCgroupV2() function to detect cgroup version 2. In cgroup v2 mode, use correct path without 'memory' subsystem 3. In cgroup v2 mode, use 'cgroup.threads' instead of 'tasks' file 4. Also update getSandboxPID function to use correct tasks file name Fixes alibaba#348
Lyt99
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #348
Problem
The tasksInsidePodCgroup function was hardcoded to use the 'memory' subsystem path and 'tasks' file, which only works with cgroup v1.
Changes
Testing