Skip to content

feat: rerun metric & aggregator if panic#2382

Open
shunjiazhu wants to merge 1 commit into
alibaba:mainfrom
shunjiazhu:feat/rerun-when-panic
Open

feat: rerun metric & aggregator if panic#2382
shunjiazhu wants to merge 1 commit into
alibaba:mainfrom
shunjiazhu:feat/rerun-when-panic

Conversation

@shunjiazhu

Copy link
Copy Markdown
Contributor

No description provided.

@Takuka0311

Takuka0311 commented Apr 27, 2026

Copy link
Copy Markdown
Collaborator

百炼自动化审查:建议保持开启。

本 PR 旨在为 metric input 与 aggregator 增加 panic 自动重启机制,提升采集链路容错能力。当前实现采用无上限的递归调用重启,存在协程泄漏与资源耗尽风险,且基线版本过旧导致合并冲突。属于需重构的有价值陈旧 PR,应保持开启等待作者迭代。.

最佳落地路径:

建议作者先将分支 rebase 至最新 main 解决冲突。将 panicCallback 中的递归调用重构为带最大重试次数与指数退避的调度重试机制(或交由上层控制循环处理),防止插件持续 panic 导致资源耗尽。补充边界测试与重试配置说明后,请求维护者复审。.

已核对内容:

百炼审查备注:模型 qwen3.6-max-preview;对照提交 d3305220b0b8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants