Fixed some race condition issues in the C++ ContainerManager module.#2532
Open
linrunqi08 wants to merge 4 commits intomainfrom
Open
Fixed some race condition issues in the C++ ContainerManager module.#2532linrunqi08 wants to merge 4 commits intomainfrom
linrunqi08 wants to merge 4 commits intomainfrom
Conversation
linrunqi08
changed the title
linrunqi08
force-pushed
the
feature/taiye/fix_cpp_container_race
branch
from
0a5a314 to
23122d4
Compare
Takuka0311
reviewed
Feb 13, 2026
| } | ||
| } | ||
|
|
||
| void ContainerManager::updateContainerInfoPointersForContainers(const std::vector<std::string>& containerIDs) { |
Collaborator
There was a problem hiding this comment.
这个函数并没有用到，我理解是不是应该要放在incrementallyUpdateContainersSnapshot里面的
| const auto& basePathInfos = options->GetBasePathInfos(); | ||
| for (const auto& info : *containerInfos) { | ||
| // Protect access to mRawContainerInfo with lock | ||
| std::lock_guard<std::mutex> lock(mContainerMapMutex); |
Collaborator
There was a problem hiding this comment.
这里锁的层次跟下面不太一样。下面for循环以外锁
| std::unordered_map<std::string, std::shared_ptr<RawContainerInfo>> containerMapSnapshot; | ||
| { | ||
| std::lock_guard<std::mutex> lock(mContainerMapMutex); | ||
| containerMapSnapshot = mContainerMap; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.