[ISSUE #14466] Remove Jackson JavaType from rest template#15369
Merged
KomachiSion merged 1 commit intoJun 17, 2026
Conversation
Resolve response handler raw classes with JDK Type APIs instead of Jackson JavaType. Add coverage for parameterized RestResult, custom parameterized responses, and unsupported Type fallback. Assisted-by: Claude Code
|
Thanks for your this PR. 🙏 感谢您提交的PR。 🙏 |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation\nPart of the Jackson 2 / Jackson 3 adapter migration for issue #14466. This step removes the direct Jackson JavaType usage from common HTTP response handler selection.\n\n### Modifications\n- Replace JacksonUtils.constructJavaType(responseType).getRawClass() in AbstractNacosRestTemplate with JDK Type raw-class resolution.\n- Preserve response handler selection for Class and ParameterizedType response types.\n- Add tests for parameterized RestResult, custom parameterized response types, and unsupported Type fallback.\n- Update docs/jackson-json-adapter-migration-todo.md with stage 6 status and validation.\n\n### Verification\n- mvn -pl common spotless:apply\n- mvn -pl common spotless:check\n- mvn -pl common -am -Dtest=AbstractNacosRestTemplateTest -Dsurefire.failIfNoSpecifiedTests=false test\n- common/target/site/jacoco/jacoco.csv: AbstractNacosRestTemplate has LINE_MISSED=0\n- mvn -pl common apache-rat:check