fix: fix Parquet array CI failures#768
Closed
shirly121 wants to merge 1 commit into
Closed
Conversation
shirly121
marked this pull request as draft
July 22, 2026 10:27
shirly121
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Fixes CI regressions in Parquet ARRAY integration tests caused by PyArrow 24 limitations and a mismatch between expected vs. actual public interval representation.
Changes:
- Removes a Parquet fixture/test that fails during PyArrow parquet write due to unsupported null fixed-size lists.
- Updates expected duration ARRAY values to match NeuG’s millisecond-string interval representation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
174
to
179
| [2, [["w", "x"], ["y", "z"]]], | ||
| ] | ||
|
|
||
| @extension_test | ||
| def test_parquet_null_array(self): | ||
| """LOAD FROM Parquet preserves a null fixed-size array.""" | ||
| pa = pytest.importorskip("pyarrow") | ||
| parquet_path = self._write_parquet( | ||
| "null_array.parquet", | ||
| { | ||
| "id": pa.array([1, 2, 3], type=pa.int64()), | ||
| "values": pa.array( | ||
| [[1.0, 2.0, 3.0], None, [7.0, 8.0, 9.0]], | ||
| type=pa.list_(pa.float32(), 3), | ||
| ), | ||
| }, | ||
| ) | ||
| self.conn.execute("LOAD PARQUET") | ||
| result = list( | ||
| self.conn.execute( | ||
| f'LOAD FROM "{parquet_path}" ' | ||
| "RETURN id, CAST(values, 'FLOAT[3]') ORDER BY id" | ||
| ) | ||
| ) | ||
|
|
||
| assert result == [ | ||
| [1, [1.0, 2.0, 3.0]], | ||
| [2, None], | ||
| [3, [7.0, 8.0, 9.0]], | ||
| ] | ||
|
|
||
| @extension_test | ||
| def test_parquet_timestamp_units(self): | ||
| """Normalize scalar and ARRAY timestamps of every Arrow unit to ms.""" |
Comment on lines
283
to
+286
| [["a", "b"], ["c", "d"]], | ||
| [date(1970, 1, 1), date(2023, 6, 15)], | ||
| [datetime(1970, 1, 1), datetime(2023, 6, 15, 12, 30)], | ||
| ["2 days", "3 hours"], | ||
| ["172800000", "10800000"], |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes CI regressions introduced by feat: support fixed-size arrays in data readers (#726).
Errors addressed
ArrowNotImplementedError: Lists with non-zero length null components are not supportedwhile creating the null fixed-size-list Parquet fixture. The failure occurs before NeuG reads the file, so the invalid integration test is removed.2 daysand3 hours), while NeuG returns INTERVAL values as millisecond strings (172800000and10800000). The expected result is updated to match the actual public representation.These failures were observed in the
extension_tests_defaultjob of run 29905233448.