refactor: remove unused timestamp parameter from Compact#771
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the unused timestamp_t parameter from the Compact APIs across the storage layer, aligning the public headers and all internal callers with the fact that compaction behavior does not depend on a timestamp.
Changes:
- Updated
PropertyGraph::Compact,VertexTable::Compact, andEdgeTable::Compactsignatures to drop the unused timestamp argument. - Updated all in-repo call sites (transaction, loader, DB checkpointing/WAL ingest paths) to call the new signatures.
- Updated unit tests to match the new API.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| include/neug/storages/graph/property_graph.h | Updates public PropertyGraph::Compact() signature to remove timestamp parameter. |
| include/neug/storages/graph/vertex_table.h | Updates public VertexTable::Compact() signature to remove timestamp parameter. |
| include/neug/storages/graph/edge_table.h | Updates public EdgeTable::Compact(sort_key_for_nbr) signature to remove timestamp parameter. |
| src/storages/graph/property_graph.cc | Updates PropertyGraph::Compact() implementation and table compaction calls to the new signatures. |
| src/storages/graph/vertex_table.cc | Updates VertexTable::Compact() implementation signature. |
| src/storages/graph/edge_table.cc | Updates EdgeTable::Compact() implementation signature. |
| src/transaction/compact_transaction.cc | Updates compaction transaction to call Compact() without a timestamp. |
| src/storages/loader/abstract_property_graph_loader.cc | Updates loader fragment finalization to call graph_.Compact() without a timestamp. |
| src/main/neug_db.cc | Updates WAL ingest and checkpointing compaction calls to use Compact() without a timestamp. |
| tests/storage/test_vertex_table.cc | Updates test to call VertexTable::Compact() with no arguments. |
| tests/storage/test_edge_table.cc | Updates test to call EdgeTable::Compact(std::nullopt) with no timestamp argument. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
liulx20
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
fix #770
What does this PR do?
Removes the unused
timestampparameter from theCompactinterface across the storage layer, since the parameter was never actually used inside the implementation.What changes in this PR?
PropertyGraph::Compact(): removed thetimestamp_t tsparameter.VertexTable::Compact(): removed thetimestamp_t tsparameter.EdgeTable::Compact(sort_key_for_nbr): removed thetimestamp_t tsparameter, keepingsort_key_for_nbr.src/transaction/compact_transaction.ccsrc/storages/loader/abstract_property_graph_loader.ccsrc/main/neug_db.cctests/storage/test_vertex_table.cctests/storage/test_edge_table.ccmake -j10build; compiles successfully with no errors.