feat(allowlist): add Jinja template support - #1056
Conversation
|
✅ OpenCodeReview: Review complete: 0 finding(s) across 2 selected item(s). |
Qiyuanqiii
left a comment
There was a problem hiding this comment.
The PR description has been flattened into a single Markdown line, so its headings, lists, and checkboxes do not render correctly. Please edit the PR description to restore the intended line breaks and blank lines.
|
@Qiyuanqiii Fixed — the PR description has been restored with its headings, lists, blank lines, and task checkboxes rendering correctly. The CLA item remains checked. Thanks for catching this! |
Qiyuanqiii
left a comment
There was a problem hiding this comment.
GitHub Linguist lists .jinja as Jinja’s primary extension. Since this PR is intentionally scoped to .jinja2 and .j2 per #1055, this does not need to block the PR, but it would be useful to track .jinja support in a follow-up issue.
46d669c to
7b7b2e9
Compare
|
@wu21-web Rebased onto the latest main ( |
wu21-web
left a comment
There was a problem hiding this comment.
Overall this is complete. I would approve this.
|
All review suggestions are addressed and checks are green — this is ready from my side whenever you'd like to merge. Thanks again for the thorough reviews! |
Co-authored-by: Tao Xin <149216116+wu21-web@users.noreply.github.com>
Co-authored-by: Tao Xin <149216116+wu21-web@users.noreply.github.com>
7054aa9 to
3736838
Compare

Description
Add first-class review support for Jinja template files as the focused subtask tracked in #1055:
.jinja2and.j2files case-insensitively;Type of Change
How Has This Been Tested?
make testpasses locallyValidation performed on Windows/amd64 with Go 1.27.0, GNU Make 4.4.1, and GCC 16.2.0:
make checkmake test(all 23 Go packages with-race -count=1)make buildgo test -race -count=1 ./internal/config/allowlist ./internal/config/rulesThe repository-required
ocr review --audience agent --background "briefly summarize the background requirements"command was attempted, but this local environment has no configured LLM endpoint. I completed a separate standards/spec self-review; both axes reported no remaining findings.Checklist
go fmt,go vet)Related Issues
Closes #1055
Part of #470