Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polish code in rules #171

Merged
merged 17 commits into from
Nov 12, 2024
Merged

polish code in rules #171

merged 17 commits into from
Nov 12, 2024

Conversation

123liuziming
Copy link
Collaborator

related to #150 and etc

@123liuziming 123liuziming changed the title polish code in rules [WIP] polish code in rules Nov 7, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 16 lines in your changes missing coverage. Please review.

Project coverage is 83.78%. Comparing base (378efdb) to head (a6c0ea3).

Files with missing lines Patch % Lines
pkg/inst-api/instrumenter/instrumenter.go 81.48% 7 Missing and 3 partials ⚠️
...api-semconv/instrumenter/db/db_client_extractor.go 81.81% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #171      +/-   ##
==========================================
+ Coverage   82.60%   83.78%   +1.17%     
==========================================
  Files          18       19       +1     
  Lines         713      771      +58     
==========================================
+ Hits          589      646      +57     
+ Misses        102      100       -2     
- Partials       22       25       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@123liuziming 123liuziming changed the title [WIP] polish code in rules polish code in rules Nov 12, 2024
@123liuziming 123liuziming requested a review from y1yang0 November 12, 2024 08:53
@NameHaibinZhang NameHaibinZhang merged commit f6f0da4 into main Nov 12, 2024
7 checks passed
@123liuziming 123liuziming deleted the feat/sync branch November 12, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants