-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: import path may have alias name #172
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #172 +/- ##
=======================================
Coverage 82.60% 82.60%
=======================================
Files 18 18
Lines 713 713
=======================================
Hits 589 589
Misses 102 102
Partials 22 22 ☔ View full report in Codecov by Sentry. |
d84a0db
to
5ad4f1e
Compare
5ad4f1e
to
22f0f51
Compare
Can I have a review? Maybe @123liuziming. The failed tests look like unrelated to this PR |
Grpc has released v1.68.0 2 days ago. I will support the latest Grpc release this week. |
Thanks! |
In hook code, if we import some package along with alias name and alias package is used within hook code, the compilation fails
In this case, we will replace
"github.com/alibaba/opentelemetry-go-auto-instrumentation/pkg/api"
to"errors"
and we have two"errors"
, which finally leads to failure.