Skip to content

fix: close panel after stopping a pending ask_user prompt#188

Open
tsubasakong wants to merge 1 commit intoalibaba:mainfrom
tsubasakong:lucas/fix-page-agent-183-close-question-panel
Open

fix: close panel after stopping a pending ask_user prompt#188
tsubasakong wants to merge 1 commit intoalibaba:mainfrom
tsubasakong:lucas/fix-page-agent-183-close-question-panel

Conversation

@tsubasakong
Copy link
Contributor

@tsubasakong tsubasakong commented Mar 10, 2026

What

Fixes a panel state bug when the agent is waiting on an ask_user prompt.

When the user clicks stop while the panel is waiting for an answer:

  • the agent now leaves the running state immediately,
  • the pending question UI is cleared,
  • the waiting promise is resolved cleanly,
  • and the panel can be closed or reused normally.

Type

  • Bug fix
  • Feature / Improvement
  • Refactor
  • Documentation
  • Website
  • Demo / Testing
  • Breaking change

Testing

  • Tested in modern browsers
  • No console errors
  • Types/doc added

Local validation:

  • npm ci
  • npm run build -w @page-agent/ui
  • npm run build -w page-agent (completed locally; the repo still prints existing package type-resolution diagnostics during build)
  • git diff --check

Closes #183

Requirements / 要求

Checklist

  • This PR is NOT generated by a bot or AI agent acting autonomously. I have authored or meaningfully reviewed every change. / 此 PR 不是由 bot 或 AI 自主生成的,我已亲自编写或充分审查了每一处变更。

@CLAassistant
Copy link

CLAassistant commented Mar 10, 2026

CLA assistant check
All committers have signed the CLA.

@tsubasakong tsubasakong force-pushed the lucas/fix-page-agent-183-close-question-panel branch from ce01bbe to 11191ca Compare March 11, 2026 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] 默认的UI,当询问用户问题的时候,点击停止和关闭没有关闭pannel

2 participants