-
Notifications
You must be signed in to change notification settings - Fork 439
Rule Manager: Improve CircuitBreaker rule loading API (#236) #257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Could you please fix CI? |
Codecov Report
@@ Coverage Diff @@
## master #257 +/- ##
==========================================
+ Coverage 43.06% 43.73% +0.66%
==========================================
Files 79 79
Lines 3994 4020 +26
==========================================
+ Hits 1720 1758 +38
+ Misses 2009 2003 -6
+ Partials 265 259 -6
Continue to review full report at Codecov.
|
Thanks @louyuting for your update. I did only send out changes on CircuitBreaker module since there are multiple changes to Flow module in the latest branch. Would love to discuss and help on other modules. Please let me know if any concerns on current implementation. |
That's great. I will review this PR. Because of holiday, the response might be later. |
Describe what this PR does / why we need it
PR per issue #236
Does this pull request fix one issue?
Add fixes to solve issue #236
Describe how you did it
Add logic to check for existing rule changes in this API and return as the first value
Put recover method in one place so that all panics can be caught and assigned to the second value
Failed rules will be returned to caller as the third value
Add duplicate rule checker so that all loaded rules will be unique
Describe how to verify it
Added more UT cases to verify it
Special notes for reviews
Also Add CB Strategy Enumeration upper boundary.
Modify API signature