Open
Conversation
|
|
sczyh30
added
kind/feature
binbin0325
reviewed
Aug 28, 2023
Collaborator
binbin0325
left a comment
binbin0325
left a comment
There was a problem hiding this comment.
for traffic governance related code, it may be better to commit pr to a separate v2 branch
Author
I don't have permission to create a new branch in this repository. Could you please help me with that? |
saicaca
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Implements #508
Does this pull request fix one issue?
Implements #508
Describe how you did it
Basically followed the design in alibaba/Sentinel#3023.
Describe how to verify it
The implementation can be verified via go test.
Special notes for reviews
This PR is currently a work in progress.