fix(graph): Fixed checkpoint state merge when in resume mode#4194
Open
PeatBoy wants to merge 5 commits intoalibaba:mainfrom
Open
fix(graph): Fixed checkpoint state merge when in resume mode#4194PeatBoy wants to merge 5 commits intoalibaba:mainfrom
PeatBoy wants to merge 5 commits intoalibaba:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Fix the parameter order issue in OverAllState.input during resume scenarios. When resuming from a checkpoint, the passed input represents the old state, while the current state holds the new value. The original implementation reversed these, causing incorrect merge behavior
Does this pull request fix one issue?
Fixed checkpoint state merge when in resume mode
Describe how you did it
Changed the strategy call in OverAllState.input from keyStrategies.get(key).apply(value(key, null), input.get(key)) to keyStrategies.get(key).apply(input.get(key), value(key, null)), ensuring that during resume, oldValue is the checkpoint’s old value and newValue is the current state’s new value
Describe how to verify it
Special notes for reviews