fix: AppendStrategy.apply method result maybe miss the "newValue"#4212
Open
dingshuangwu wants to merge 2 commits intoalibaba:mainfrom
Open
fix: AppendStrategy.apply method result maybe miss the "newValue"#4212dingshuangwu wants to merge 2 commits intoalibaba:mainfrom
dingshuangwu wants to merge 2 commits intoalibaba:mainfrom
Conversation
…is not a list object and newValue is a list object.
dingshuangwu
changed the title
dingshuangwu
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
The AppendStrategy.apply result miss the newValue when oldValue is not a list object and newValue is a list object.
Does this pull request fix one issue?
Yes, It fixed one issue and optimize a "if-else" logic branch.
Describe how you did it
1.Removed lines 81 and 94, the line 81 always be true because the line 75 is true.
2.Fixed the "newValue" missed logic for line 106
Describe how to verify it
Special notes for reviews