fix(graph): preserve RunnableConfig context in compiled subgraph#4275
Open
OiPunk wants to merge 1 commit intoalibaba:mainfrom
Open
fix(graph): preserve RunnableConfig context in compiled subgraph#4275OiPunk wants to merge 1 commit intoalibaba:mainfrom
OiPunk wants to merge 1 commit intoalibaba:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
This PR fixes context propagation for compiled subgraphs.
RunnableConfig.contextis meant to carry per-run mutable data across nodes, butSubCompiledGraphNodeActioncleared context before invoking the compiled subgraph, causing data loss.Does this pull request fix one issue?
Fixes #4191
Describe how you did it
subGraphRunnableConfig.clearContext()inSubCompiledGraphNodeActionso subgraph execution keeps parent run context.testCompiledSubGraphShouldInheritRunnableContextinCompiledSubGraphTest.trace_idintoRunnableConfig.context.[SUB:ctx-123].Describe how to verify it
Run:
JAVA_HOME=/usr/local/opt/openjdk@17/libexec/openjdk.jdk/Contents/Home ./mvnw -pl spring-ai-alibaba-graph-core -am testResult:
Tests run: 277, Failures: 0, Errors: 0, Skipped: 52Special notes for reviews