feat: Add NacosServiceInstanceConverter util - #3686
Open
karsonto wants to merge 2 commits into
Open
Conversation
|
|
Collaborator
|
Can you explain why it was modified in this way? |
Author
This design can make the conversion between nacos Instance and spring cloud ServiceInstance clearly. |
oss-sentinel-ai
approved these changes
Jul 21, 2026
oss-sentinel-ai
left a comment
oss-sentinel-ai
left a comment
There was a problem hiding this comment.
Summary
LGTM — clean refactoring that extracts Instance ↔ ServiceInstance conversion logic into a dedicated NacosServiceInstanceConverter utility class with a builder pattern. This eliminates duplicated conversion code in NacosBalancer and NacosServiceDiscovery.
Review Notes
- Good use of builder pattern for bidirectional conversion
- Private constructor prevents instantiation — correct for a utility class
- Minor: The indentation in
NacosBalancerchanged from 1-tab to 2-tab. Consider aligning with the existing codebase style to minimize diff noise.
Automated review by github-manager-bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
some enhancement for nacos discovery