bugfix enable wrapper openfeign client with spring-cloud-circuitbreak… - #3980
Open
TianMing2018 wants to merge 5 commits into
Open
bugfix enable wrapper openfeign client with spring-cloud-circuitbreak…#3980TianMing2018 wants to merge 5 commits into
TianMing2018 wants to merge 5 commits into
Conversation
|
|
…sed on it will fail directly since 2025-02-01)
oss-sentinel-ai
left a comment
oss-sentinel-ai
left a comment
There was a problem hiding this comment.
Summary
This PR bundles multiple example/config updates (MySQL driver class, RocketMQ hostname, Dockerfiles, Helm charts, docs) together with an OpenFeign @PathVariable annotation fix. The changes are reasonable but span 36 files across different concerns.
Review Notes
@PathVariable(value = "ok")fix — Correct. Without-parameterscompiler flag, Spring needs the explicitvalueattribute to resolve path variable names. This is a valid fix.- MySQL driver update (
com.mysql.jdbc.Driver→com.mysql.cj.jdbc.Driver) — Good catch, the old class is deprecated. - RocketMQ hostname changes — Switching from hardcoded IP to service name (
rocketmq-server) improves Docker Compose portability. - Scope concern: This PR mixes bugfixes, config updates, Dockerfile changes, and documentation updates. For future PRs, consider splitting these into separate commits or PRs for easier review and backporting.
- Backport note: If these example fixes apply to maintained branches (2025.1.x, 2025.0.x), please mention target branches in the PR description.
Automated review by github-manager-bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
refer to issue #3979
it will fix sample
sentinel-circuitbreaker-example, make it return fallback info by enable wrapper openfeign client with spring-cloud-circuitbreak…Does this pull request fix one issue?
Fixes #3979 sentinel-feign.FeignException$InternalServerError #3979
Describe how you did it
enable
spring.cloud.openfeign.circuitbreaker.enabledDescribe how to verify it
git clone https://github.com/alibaba/spring-cloud-alibaba -b 2023.xspring.cloud.openfeign.circuitbreaker.enableduser fallbackSpecial notes for reviews
Maybe we should shade starter
spring-cloud-circuitbreaker-sentinel, toggle state withspring.cloud.circuitbreaker.sentinel.enabled