upgrade schedulerx version - #4030
Conversation
oss-sentinel-ai
left a comment
There was a problem hiding this comment.
Summary
This PR upgrades schedulerx.worker from 1.11.4 to 1.13.1 and adapts the integration code for API changes. The version bump and code adaptations look reasonable, but there are concerns worth addressing.
Findings
-
[Warning] The PR body is empty — no justification for the version upgrade, no changelog reference, and no mention of breaking changes. Please add a description explaining:
- What changed in schedulerx 1.13.1 vs 1.11.4
- Whether there are known breaking changes or migration notes
- Link to the schedulerx release notes if available
-
[Warning]
SchedulerxProperties.java: The defaultlabelPathchanged from/etc/podinfo/annotationsto/etc/podinfo/labels. This is a behavioral change that could affect existing deployments relying on the annotations-based label discovery. Please document this in the PR description and consider whether a deprecation path or migration guide is needed. -
[Info]
ScheduledJobSyncConfigurer.java: The switch from@Autowired SchedulerxSchedulingConfigurertoSchedulerxJobRegister.getInstance()(static singleton) is a significant architectural change. Please confirm this is intentional and document the rationale.
Suggestions
Please fill in the PR description with upgrade justification and migration notes before merge.
Automated review by github-manager-bot
Describe what this PR does / why we need it
Does this pull request fix one issue?
Describe how you did it
Describe how to verify it
Special notes for reviews