Skip to content

fix: handle NPE when NotifyCenter.INSTANCE is null during graceful shutdown #4284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Senrian wants to merge 1 commit into
base: 2025.1.x
Choose a base branch
from
Open

fix: handle NPE when NotifyCenter.INSTANCE is null during graceful shutdown #4284

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions ...scovery/src/main/java/com/alibaba/cloud/nacos/registry/NacosGracefulShutdownDelegate.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
* Copyright 2013-present the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
* you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
Expand Down Expand Up @@ -75,6 +75,11 @@ protected void doGracefulShutdown() {
log.info("Nacos client graceful shutdown has been executed successfully. " +
"Graceful shutdown wait time is {}", gracefulShutdownWaitTime);
}
catch (NullPointerException e) {
// Ignore NPE during shutdown when NotifyCenter.INSTANCE has been destroyed
log.warn("Nacos client graceful shutdown encountered NPE (NotifyCenter may already be destroyed). " +
"This is safe to ignore during shutdown.", e);
}
catch (Throwable t) {
log.error("Error occurred while performing Nacos client graceful shutdown", t);
}
Expand Down