[build] declare kvcm_ops wheel runtime dependency - #304
Open
wangxiyu191 wants to merge 1 commit into
Open
Conversation
wangxiyu191
requested review from
PerryZZ,
charpty,
lucky-zzz,
oldsharp and
xiqi-lq
as code owners
August 24, 2026 04:24
There was a problem hiding this comment.
Overall this looks like a clean, focused fix: it centralizes the requests requirement, declares it as a runtime dependency of the kvcm_ops wheel, and adds regression coverage for wheel metadata and installation.
Notes / questions:
- Verified that the pinned
rules_pythoncommit (084b877c) already supportsrequires_fileonpy_wheel, so the new attribute is safe. open_source/deps/BUILDcorrectly addsrequirements_kvcm_ops.txttoexports_filesandextra_data, which is needed now thatrequirements_base.txtincludes it via-r.- The lock-file annotation changed to
# via -r open_source/deps/././requirements_kvcm_ops.txt. This is only cosmetic, but make sure it was produced by the project's pinnedpip-compileinvocation and not hand-edited; otherwise regenerating the lock file may revert it. wheel_install_test.pycreates a clean venv and installs from PyPI. As noted inline, this introduces a network dependency and a requirement that the Bazel Python runtime hasensurepip. If CI runners are sometimes firewalled or use a stripped Python, this could become flaky.- Minor: the typo in the assertion string (
"kvcm: list_intance.") matches the existing source, so the test is consistent; no change needed unless you want to fix the source separately.
🤖 Generated by Qoder
| self.assertEqual(0, result.returncode, msg=result.stdout) | ||
| return result.stdout | ||
|
|
||
| def test_install_resolves_requests_and_starts_http_command(self): |
There was a problem hiding this comment.
This is a useful regression test, but be aware it depends on the CI runner having outbound PyPI access and a base Python with ensurepip. If either is unavailable, the normal_test shard will fail. Consider documenting this requirement or adding tags = ["manual"] if network access is not guaranteed.
🤖 Generated by Qoder
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests