Open
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes incorrect multipath reporting when using FEC in back_fec mode by ensuring fec_rep_path_id is updated during path selection for repair-symbol packets.
Changes:
- Update
fec_rep_path_idinsidexqc_backup_fec_scheduler_get_path()when selecting a path for repair-symbol traffic in standby-based FEC MP mode. - Record standby path id or reset to a sentinel value depending on the selected path’s status.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
+190
to
+193
| conn->fec_ctl->fec_rep_path_id = | ||
| (ret_path->app_path_status == XQC_APP_PATH_STATUS_STANDBY) | ||
| ? ret_path->path_id | ||
| : XQC_MAX_UINT64_VALUE; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the fix for incorrect report for multipath transmission in backup_fec mode, here is the critical logs:
The scheduler
xqc_backup_fec_scheduler_cbnever update fec_rep_path_id which should be an unexpected behavior.