Skip to content

Conversation

@982945902
Copy link
Contributor

Why

support direct only mode read on lunux

What is changing

pass O_DIRECT flag to fd inlcude native and boost file

Example

coro_io::basic_random_coro_file<coro_io::execution_type::thread_pool> file(executor);
bool opened = file.open(filename, std::ios::in | std::ios::binary, true);

@qicosmos
Copy link
Collaborator

Please add unit tests to cover your newly added code.

@982945902
Copy link
Contributor Author

Please add unit tests to cover your newly added code.

done

@qicosmos
Copy link
Collaborator

Please use clang-format-13 to format the code and fix mac compile error.

@github-actions
Copy link

for detail, goto summary download Artifacts base-ylt-cov-report(base commit coverage report) and ylt-cov-report(current pull request coverage report)

@github-actions
Copy link

for detail, goto summary download Artifacts base-ylt-cov-report(base commit coverage report) and ylt-cov-report(current pull request coverage report)

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ 982945902
❌ lishuo121


lishuo121 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions
Copy link

for detail, goto summary download Artifacts base-ylt-cov-report(base commit coverage report) and ylt-cov-report(current pull request coverage report)

@github-actions
Copy link

for detail, goto summary download Artifacts base-ylt-cov-report(base commit coverage report) and ylt-cov-report(current pull request coverage report)

@982945902
Copy link
Contributor Author

Please use clang-format-13 to format the code and fix mac compile error.

done

@qicosmos qicosmos self-requested a review December 31, 2025 07:03
Copy link
Collaborator

@qicosmos qicosmos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qicosmos qicosmos merged commit 087d8c6 into alibaba:main Dec 31, 2025
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants