fix(thread-pool): fix thread count vs binding constructor bug#585
Open
luoxiaojian wants to merge 4 commits into
Open
fix(thread-pool): fix thread count vs binding constructor bug#585luoxiaojian wants to merge 4 commits into
luoxiaojian wants to merge 4 commits into
Conversation
luoxiaojian
requested review from
Cuiyus,
chinaux,
richyreachy and
zhourrr
as code owners
July 10, 2026 07:40
luoxiaojian
requested review from
JalinWang,
feihongxu0824 and
iaojnh
as code owners
July 10, 2026 09:57
zhourrr
reviewed
Jul 14, 2026
zhourrr
reviewed
Jul 14, 2026
|
|
iaojnh
reviewed
Jul 21, 2026
Collaborator
There was a problem hiding this comment.
这里的size貌似没有做限制，是用户输入的。
如果这个值很大，比如100万，pool_里可能有构造失败不可用的worker。
可以考虑在哪里加个校验或者截断
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.