[meshroom] CameraInit: Remove _cmdVars
#2001
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbentejac
force-pushed
the
dev/expressionVars
branch
2 times, most recently
from
51fdd6c to
2ee3b68
Compare
cbentejac
changed the title
CameraInit: Replace _cmdVars with _expVarsCameraInit: Remove _cmdVars
`_cmdVars` does not exist anymore and `node.internalFolder` now contains the resolved path. There is thus no need to format it anymore.
cbentejac
force-pushed
the
dev/expressionVars
branch
from
2ee3b68 to
6608974
Compare
fabiencastan
approved these changes
Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As a consequence of alicevision/Meshroom#2888,
_cmdVars, which was used inCameraInit, does not exist anymore andnode.internalFoldernow contains the resolved path. There is thus no need to format it anymore..format(**node._cmdVars)is thus fully removed.