Open
Conversation
servantftransperfect
force-pushed
the
dev/UsdExporter
branch
from
9220d09 to
fe62c0b
Compare
servantftransperfect
force-pushed
the
dev/UsdExporter
branch
from
fe62c0b to
36378ac
Compare
servantftransperfect
force-pushed
the
dev/UsdExporter
branch
from
36378ac to
970ebb9
Compare
servantftransperfect
force-pushed
the
dev/UsdExporter
branch
from
970ebb9 to
a124ad7
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a new OpenUSD camera exporter path for SfM scenes, while preserving the previous mesh-to-USD functionality under a renamed exportMeshUSD tool. It also wires the new exporter into both CMake and Meshroom nodes.
Changes:
- Repurposes
aliceVision_exportUSDto export animated cameras from SfMData via a newsfmDataIO::UsdExporter. - Adds
aliceVision_exportMeshUSDas the renamed mesh/textures USD exporter (formerexportUSDbehavior). - Updates build configuration and Meshroom node definitions to expose both exporters.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
src/software/export/main_exportUSD.cpp |
New CLI flow exporting cameras from SfMData to USD via UsdExporter. |
src/software/export/main_exportMeshUSD.cpp |
New (renamed) mesh/textures USD exporter CLI implementation. |
src/software/export/CMakeLists.txt |
Adds aliceVision_exportMeshUSD and redefines aliceVision_exportUSD. |
src/aliceVision/sfmDataIO/UsdExporter.hpp |
Declares the new USD exporter API. |
src/aliceVision/sfmDataIO/UsdExporter.cpp |
Implements USD stage/camera/time-sampled transform export. |
src/aliceVision/sfmDataIO/CMakeLists.txt |
Registers/links UsdExporter when USD is available. |
meshroom/aliceVision/ExportUSD.py |
Updates the Meshroom node to match new exportUSD camera-export behavior. |
meshroom/aliceVision/ExportMeshUSD.py |
Adds a Meshroom node for the renamed mesh exporter. |
.gitignore |
Formatting-only adjustment. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
servantftransperfect
force-pushed
the
dev/UsdExporter
branch
from
e56757c to
6a6021f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ExportUSDtoExportMeshUSDExportAlembicbut exporting to OpenUSDExportUSDUSDExporterwhich does the communication with USD api to create USD file.