[bug] fix popsift static release#807
Merged
fabiencastan merged 8 commits intodevelopfrom Jun 16, 2020
Merged
Conversation
fixes a bug appearing after alicevision/popsift/pull/71
fabiencastan
approved these changes
Jun 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since alicevision/popsift/pull/71, popsift is now always releasing the resources with the destructor.
In our implementation of
ImageDescriber_SIFT_popSIFTpopsift is a static member of the class to avoid multiple instances of the Cuda run-time.Since static object are destroyed last, it happens in
alicevision_extractFeaturesthat the popsift destructor tries to release resource when the Cuda runtime is already shut down.This causes an error on exit from the program:
In order to fix the problem, a static counter in the class
ImageDescriber_SIFT_popSIFThas been added to count how many instances of the class there are and when the last one is destroyed, also the static popsift is destroyed (the old good "the last one shut the door" principle :-) )This is a mitigating solution in that it is efficient in managing multiple instances of
ImageDescriber_SIFT_popSIFTrunning at the same time, but obviously it has the drawback that it introduces overheads for allocating/deallocating cuda stuff when severalImageDescriber_SIFT_popSIFTinstances are created and destroyed in sequence.In alicevision
ImageDescriber_SIFT_popSIFTat the moment is only used with a single instance so there are no issues.Incidentally, it cleans up a little the constructors/destructors of the other feature classes with missing
explicit,defaultandoverride. Sorry, the OCD kicked in. :-)