Skip to content

Commit 0bf2c41

Browse files
Fabien Servantcbentejac
authored andcommitted
Use pixel aspect ratio for 3d viewer
1 parent 648b095 commit 0bf2c41

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

meshroom/ui/qml/Viewer3D/Viewer3D.qml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -248,7 +248,7 @@ FocusScope {
248248
sourceComponent: ImageOverlay {
249249
id: imageOverlay
250250
source: root.viewpoint.undistortedImageSource
251-
imageRatio: root.viewpoint.orientedImageSize.width / root.viewpoint.orientedImageSize.height
251+
imageRatio: root.viewpoint.orientedImageSize.width * root.viewpoint.pixelAspectRatio / root.viewpoint.orientedImageSize.height
252252
uvCenterOffset: root.viewpoint.uvCenterOffset
253253
showFrame: Viewer3DSettings.showViewpointImageFrame
254254
imageOpacity: Viewer3DSettings.viewpointImageOverlayOpacity

meshroom/ui/reconstruction.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -367,6 +367,14 @@ def fieldOfView(self):
367367
else:
368368
sensorHeight = self.solvedIntrinsics["sensorHeight"]
369369
return 2.0 * math.atan(float(sensorHeight) / (2.0 * float(focalLength))) * 180.0 / math.pi
370+
371+
@Property(type=float, notify=sfmParamsChanged)
372+
def pixelAspectRatio(self):
373+
""" Get camera pixel aspect ratio. """
374+
if not self.solvedIntrinsics:
375+
return 1.0
376+
377+
return float(self.solvedIntrinsics["pixelRatio"])
370378

371379
@Property(type=QUrl, notify=undistortedImageParamsChanged)
372380
def undistortedImageSource(self):

0 commit comments

Comments
 (0)