Skip to content

Commit 248229e

Browse files
committed
[GraphEditor] Node: Check if unexposed ListAttributes contain links
If unexposed attributes (ie. attributes that are located in the lower side of a node, and hidden by default) are connected, they are meant to remain visible even if the lower part of that node is hidden. This was working fine for any attribute that was not a `ListAttribute`, as the check was made on whether the attribute's value was a link to another attribute. For `ListAttributes`, whose value is actually a list of values, this was not working as nested links were not checked. Instead of relying on the `isLink` property, we now use `isLinkNested`: for regular attributes, this is equivalent to using `isLink`, but for `ListAttributes`, the full list of values will be checked.
1 parent 648b095 commit 248229e

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

meshroom/ui/qml/GraphEditor/Node.qml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -495,8 +495,8 @@ Item {
495495
delegate: Loader {
496496
id: paramLoader
497497
active: !object.isOutput && !object.desc.exposed && object.desc.visible
498-
visible: Boolean(object.enabled || object.isLink || object.hasOutputConnections)
499-
property bool isFullyActive: Boolean(m.displayParams || object.isLink || object.hasOutputConnections)
498+
visible: Boolean(object.enabled || object.isLinkNested || object.hasOutputConnections)
499+
property bool isFullyActive: Boolean(m.displayParams || object.isLinkNested || object.hasOutputConnections)
500500
width: parent.width
501501

502502
sourceComponent: AttributePin {

0 commit comments

Comments
 (0)