[Viewer] Display error labels when an image cannot be loaded #2250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbentejac
force-pushed
the
dev/catchMissingFile
branch
from
034cb11 to
d1badc2
Compare
cbentejac
force-pushed
the
dev/catchMissingFile
branch
from
d1badc2 to
d16b57c
Compare
cbentejac
changed the title
Based on QtAliceVision's global status for the FloatImageViewer, display a specific label when an error has been encountered. The content of the label depends on the type of the error.
cbentejac
force-pushed
the
dev/catchMissingFile
branch
from
d16b57c to
64c56e0
Compare
fabiencastan
approved these changes
Dec 19, 2023
This was referenced Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When an image cannot be loaded in the 2D Viewer, for example when visualizing the output of a node while an image whose viewpoint does not correspond to any output image is selected in the Image Gallery, the viewer remained in a loading state. The only way to get out of it was to try and load another image successfully.
This PR stops displaying a loading icon as soon as it has been detected that the image could not be loaded, basing itself on the FloatImageViewer's global status, which is updated in QtAliceVision: the viewer is cleared and the error message corresponding to the global status is displayed (in the case described above: "Missing File").
This relates to alicevision/QtAliceVision#57.