[ui] Add new FilterComboBox for ChoiceParam attributes #2358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiencastan
reviewed
Apr 3, 2024
Just-Kiel
force-pushed
the
dev/combobox
branch
3 times, most recently
from
e9358d3 to
3a66f42
Compare
Following the modifications that introduce the dynamic choices, we use the list of attributes instead of the description of the attributes.
ChoiceParams that had their available values described in a tuple need to be updated to a list to be able to handle dynamic values.
cbentejac
approved these changes
Apr 9, 2024
cbentejac
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filter ComboBox created as single component and used in AttributeEditor.
It has a filter text section making the results sorted by relevance (first if starting by the filter text and after if includes it). Filter TextArea becomes red when no results are found and display all the original list.
Linked to #2350 to have a better UI for it.