Skip to content

Conversation

@gregoire-dl
Copy link
Member

Description

Add the new QtAliceVision 2D viewer with toolbar and a new light direction controller.

A normal map with two light directions.

Add the ability to change the camera-relative light direction in the 3D viewer

Same object with two different light directions using the new light direction controller.

Improve SphereDetection widget in order to handle automatic detection of calibration spheres.

Automatically detected calibration sphere shown with the green circle.

Features list

  • Improve SphereDetection widget in order to handle automatic detection of calibration spheres.
  • Add the new QtAliceVision 2D viewer with Blinn-Phong model with shader control toolbar and light direction toolbar.
  • Add the ability to change the camera-relative light direction in the 3D viewer.

Implementation remarks

This PR is based on the Qt6 migration branch: https://github.com/alicevision/Meshroom/tree/dev/qt6.6
Linked to QtAliceVision PR: alicevision/QtAliceVision#72

@gregoire-dl gregoire-dl added feature new feature (proposed as PR or issue planned by dev) review labels Jun 19, 2024
@gregoire-dl gregoire-dl self-assigned this Jun 19, 2024
@cbentejac cbentejac force-pushed the dev/qt6.6_phongImageViewer branch from df3239d to 8f8d8aa Compare July 4, 2024 14:55
@cbentejac cbentejac force-pushed the dev/qt6.6 branch 4 times, most recently from 44021cc to 44ea158 Compare October 3, 2024 09:30
@cbentejac cbentejac force-pushed the dev/qt6.6_phongImageViewer branch from 8f8d8aa to 68ee345 Compare October 11, 2024 17:21
@cbentejac cbentejac force-pushed the dev/qt6.6 branch 2 times, most recently from e7e2e2d to f818005 Compare October 17, 2024 13:28
Use a single light entity instead of one per camera.
Use directional light instead of point light.
Add camera relative directional light controller.
Default camera up should be accurate and consistent with camera view center.
Default camera up vector is not refresh or checked when default camera view center is set.
@cbentejac cbentejac force-pushed the dev/qt6.6_phongImageViewer branch from 68ee345 to a5cb28f Compare November 14, 2024 09:44
@cbentejac cbentejac added this to the Meshroom 2024.1.0 milestone Nov 14, 2024
@cbentejac cbentejac merged commit 5fca8a7 into dev/qt6.6 Nov 14, 2024
2 checks passed
@cbentejac cbentejac deleted the dev/qt6.6_phongImageViewer branch November 14, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature new feature (proposed as PR or issue planned by dev) review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants