[nodes] LdrToHdr: Move import of pyalicevision within functions
#2569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiencastan
approved these changes
Oct 15, 2024
Since `pyalicevision`, which is provided outside of Meshroom's repository, is now needed for all the LdrToHdr nodes, importing `pyalicevision` at the function level rather than at the file level allows the CI to pass even if `pyalicevision` is not available.
cbentejac
force-pushed
the
dev/pyavImports
branch
from
0654247 to
cb43fd4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since
pyalicevision, which is provided outside of Meshroom's repository, is now needed for all the LdrToHdr nodes, importingpyalicevisionat the function level rather than at the file level allows the CI to pass even ifpyalicevisionis not available.This PR does not fix the import and use of these nodes in Meshroom if
pyalicevisionis unavailable.